-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI runners matrix (ubuntu 20.04, 22.04) #3409
Conversation
/retest |
c39b168
to
1546c5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm Failing tests are for the |
.github/workflows/docker.yaml
Outdated
@@ -14,7 +14,7 @@ permissions: | |||
jobs: | |||
docker: | |||
name: Docker | |||
runs-on: ubuntu-20.04 | |||
runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to keep 20.04 too to test cgroup v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is a good suggestion, is prow using cgroupsv2 @BenTheElder ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is a good suggestion, is prow using cgroupsv2 @BenTheElder ?
AFAIK the GKE clusters are not yet, though it's possible to do that. kubernetes/k8s.io#5276
I'm not sure for the EKS cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should depend on which cgroups the prowjobs are on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @yankay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too early to drop cgroup v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AkihiroSuda
The code has been changed to keep Ubuntu 20.04 and add Ubuntu 22.04 to "docker CI."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the final state? Ubuntu 20.04 equal to.cgroupsv1 testing and 22.04 to cgroupsv2 ?
If that's the case can we make it more evident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, nevermind, I'll figure it out later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this makes.the ci to.run 14 jobs on presubmit, seems excessive
431cac5
to
e3e8ef3
Compare
e3e8ef3
to
47158fe
Compare
47158fe
to
b14f93b
Compare
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
b14f93b
to
21cdb55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AkihiroSuda, yankay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I´m going to close these as this will make the presubmits too expensive to maintain (in terms of support and time to run) for any PR |
Upgrade the CI environment by adding the ubuntu 22.04 to the CI.