-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure update-ca-certificates during startup #3682
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anthr76 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @anthr76! |
Hi @anthr76. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -567,6 +567,7 @@ fix_product_name | |||
fix_product_uuid | |||
select_iptables | |||
enable_network_magic | |||
update-ca-certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how much time does this take when it isn't mounted?
we're generally pretty sensitive to startup time and we might be able to do something more clever if this is slow
it's also unnecessary when the container is restarted, right? (unless certs were updated in between ...)
Right now those mounting certs can run this manually (we could even provide a daemonset or script for this), but most users who are not doing this have zero impact. I don't think this is strictly a fix and I'm not sure this is the right approach to making additional certs easier. |
Related issue #2826
In some environments it's common to configure Podman/Docker to unconditionally mount in certificates with all containers via mounts.conf
This ensures during bootup
update-ca-certificates
is ran