-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make /var a runtime volume #779
Conversation
/hold |
/hold cancel |
mount --make-shared / | ||
mount --make-shared /run | ||
mount --make-shared /var/lib/containerd | ||
mount --make-rshared / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is recursive, and from upstream (difficult to find docs for this though...)
we don't know what mounts users will try to propagate, so everything is made shared
we need this change not just because it's more correct, but because /var/lib/containerd is no longer a mount point
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Per the Filesystem Hierarchy Standard all of
/var
is persistent runtime files. This should not be on the container filesystem.Moving this to a runtime anonymous volume for all of
/var
:/var/...
volumes in the base image (for container runtime storage, which must not be stacked)/var
goes to a volume instead of the container filesystemThe only downside is that new kind images will require a new version of kind. Images built prior to this should continue to work even with the new version.
While doing this I also normalized on long flags for node creation for clarity and consistency.