Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Added unit test of iptables #284

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

yashsingh74
Copy link
Contributor

This PR includes the unit test of iptables.

Output:

> go test iptables_test.go -v
=== RUN   TestParseIPTablesData
=== RUN   TestParseIPTablesData/basic_test
=== RUN   TestParseIPTablesData/not_enough_tables
=== RUN   TestParseIPTablesData/trailing_junk
=== RUN   TestParseIPTablesData/bad_start_line
=== RUN   TestParseIPTablesData/no_nat
=== RUN   TestParseIPTablesData/no_filter
--- PASS: TestParseIPTablesData (0.00s)
    --- PASS: TestParseIPTablesData/basic_test (0.00s)
    --- PASS: TestParseIPTablesData/not_enough_tables (0.00s)
    --- PASS: TestParseIPTablesData/trailing_junk (0.00s)
    --- PASS: TestParseIPTablesData/bad_start_line (0.00s)
    --- PASS: TestParseIPTablesData/no_nat (0.00s)
    --- PASS: TestParseIPTablesData/no_filter (0.00s)
PASS
ok  	command-line-arguments	0.389s

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yashsingh74 / name: Yash Singh (0ba2de3)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 4, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yashsingh74!

It looks like this is your first PR to kubernetes-sigs/kpng 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kpng has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2022
@jayunit100
Copy link
Contributor

thank you ! rebase then we can merge

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 14, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2022
@jayunit100
Copy link
Contributor

Hi @yashsingh74 can you file an issue for this ? Just to clarify what parts of the existing codebase were adding test coverage for

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2022
@jayunit100
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, yashsingh74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit f6e0614 into kubernetes-retired:master Oct 21, 2022
@yashsingh74 yashsingh74 deleted the yash_iptables branch October 22, 2022 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants