-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Docs say use semver but linter enforces a 'v' to be prefixed. #2191
Comments
This is a bit of a bike shedding discussion. The ecosystem already broadly adopts the v prefix. We can remove there restriction in the future. I doubt we are tied to it. |
I agree. At the minimum, it would be helpful to note in the docs that "v" is required. The docs say "# 'version' is a valid semantic version string (see semver.org)" and then semver.org proceeds to say that "v" is not valid semantic versioning. https://krew.sigs.k8s.io/docs/developer-guide/plugin-manifest/ |
Ack, feel free to send a patch editing the comment on the inline yaml. |
@ahmetb: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahmetb: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahmetb done |
https://semver.org/#is-v123-a-semantic-version
https://github.com/kubernetes-sigs/krew/blob/eda76d9eb403f290d3f25b7b2930b51f170a1312/internal/installation/semver/version.go#L45
Why is 'v' forced to be present, while stating we should use semver versioning?
The text was updated successfully, but these errors were encountered: