-
Notifications
You must be signed in to change notification settings - Fork 369
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Add helpers for paths of plugin receipts * Add google/go-cmp for expressive diffs in test assertions * Remove plugin receipt on uninstall * Save plugin manifest in receipt directory * Load plugin manifest from receipts directory or the index * Do not expect specific folder layout in LoadPluginFileFromFS * Fix godoc for environment paths * Review comments * Swap plugin install and saving receipts Saving receipts is less prone to failure than the whole plugin installation. When swapped, krew will have an inconsistent state in fewer occasions. * Add test to ensure LoadManifestFromReceiptOrIndex returns ENOENT error when plugin does not exist * Put receipts in folder 'receipts' instead of 'receipts/krew-index' * Fix linter issues * Rename ReceiptsPath -> InstallReceiptPath * Save the new install receipt when upgrading a plugin
- Loading branch information
1 parent
82a267d
commit 1831b1b
Showing
41 changed files
with
4,223 additions
and
25 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// Copyright 2019 The Kubernetes Authors. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package info | ||
|
||
import ( | ||
"os" | ||
|
||
"github.com/golang/glog" | ||
"github.com/pkg/errors" | ||
|
||
"sigs.k8s.io/krew/pkg/environment" | ||
"sigs.k8s.io/krew/pkg/index" | ||
"sigs.k8s.io/krew/pkg/index/indexscanner" | ||
) | ||
|
||
// LoadManifestFromReceiptOrIndex tries to load a plugin manifest from the | ||
// receipts directory or from the index directory if the former fails. | ||
func LoadManifestFromReceiptOrIndex(p environment.Paths, name string) (index.Plugin, error) { | ||
receipt, err := indexscanner.LoadPluginFileFromFS(p.InstallReceiptPath(), name) | ||
|
||
if err == nil { | ||
glog.V(3).Infof("Found plugin manifest for %q in the receipts dir", name) | ||
return receipt, nil | ||
} | ||
|
||
if !os.IsNotExist(err) { | ||
return index.Plugin{}, errors.Wrapf(err, "loading plugin %q from receipts dir", name) | ||
} | ||
|
||
glog.V(3).Infof("Plugin manifest for %q not found in the receipts dir", name) | ||
return indexscanner.LoadPluginFileFromFS(p.IndexPluginsPath(), name) | ||
} |
Oops, something went wrong.