Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore use of t.TempDir() #696

Closed
ahmetb opened this issue Mar 11, 2021 · 3 comments · Fixed by #702
Closed

Explore use of t.TempDir() #696

ahmetb opened this issue Mar 11, 2021 · 3 comments · Fixed by #702
Assignees
@Evalle
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@ahmetb
Copy link
Member

ahmetb commented Mar 11, 2021 •
edited
Loading

Go 1.15 started offering t.TempDir() function https://golang.org/doc/go1.15#io/ioutil
We can now deprecate our implementation of testutil.NewTempDir(t).

/help-wanted
/good-first-issue
@k8s-ci-robot
Copy link
Contributor

@ahmetb:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Go 1.15 started offering t.TempDir() function https://golang.org/doc/go1.15#io/ioutil
We can now deprecate our implementation of testutil.NewTempDir(t).

/help-wanted
/good-first-issue
/kind testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 11, 2021
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Mar 11, 2021
@Evalle
Copy link
Contributor

Evalle commented Mar 12, 2021

Hi, I would like to contribute.
/assign

@ahmetb
Copy link
Member Author

ahmetb commented Mar 12, 2021

@Evalle go for it! thanks for signing up.

@Evalle Evalle mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evalle Evalle

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE-696: Explore use of t.TempDir() Evalle/krew
3 participants
@ahmetb @Evalle @k8s-ci-robot