hack: consistent checksums for archive files #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "gzip -n" to prevent gzip from changing timestamps and touch all timestamps for files in out/bin with a static value to ensure .zip checksum consistency. Fixes kubernetes-sigs#112. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
|
/cc @lbb |
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 51.64% 51.64%
=======================================
Files 12 12
Lines 608 608
=======================================
Hits 314 314
Misses 244 244
Partials 50 50Continue to review full report at Codecov.
|
|
Rebuilding a travis build produced consistent checksums, but ideally we'd need to pin to a go compiler/runtime version, too. I don't see a need for that yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "gzip -n" to prevent gzip from changing timestamps and touch all timestamps
for files in out/bin with a static value to ensure .zip checksum consistency.
Fixes #112.