Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OWNERS, kubernetes project template files #161

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Add OWNERS, kubernetes project template files #161

merged 1 commit into from
Mar 15, 2019

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Mar 14, 2019

@codecov-io
Copy link

codecov-io commented Mar 14, 2019 •
edited

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   50.91%   50.91%           
=======================================
  Files          13       13           
  Lines         711      711           
=======================================
  Hits          362      362           
  Misses        297      297           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c931212...5cab210. Read the comment docs.

nikhita
nikhita reviewed Mar 14, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@nikhita nikhita mentioned this pull request Mar 14, 2019
Merged
nikhita
nikhita approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahmetb ahmetb merged commit 3c0eced into kubernetes-sigs:master Mar 15, 2019
rlenferink
rlenferink reviewed Mar 17, 2019
View reviewed changes
OWNERS_ALIASES
@@ -0,0 +1,4 @@
aliases:
krew-index-maintainers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the krew-maintainers and krew-index-maintainers were swapped by accident.

Probably this one should be krew-maintainers and this one 8888595ca25a7a48c303fbc07f369b2db9b95268/OWNERS_ALIASES#L2 should be krew-index-maintainers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh my bad. I think I’ll do both krew-maintainers if that makes it easier. I suspect we’ll revise them in the future again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, it doesn't really matter. The teams in the OWNERS files need to be defined in the OWNERS_ALIASES file per repository. Till the moment we can use GitHub teams for this, it is necessary to have the data available in the OWNERS* files for both repositories.

So it is completely up to you if you want to 'combine' or keep the repositories separate (different contributors/maintainers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlenferink rlenferink rlenferink left review comments

@nikhita nikhita nikhita approved these changes

Assignees
No one assigned
Labels
deprecated/google-cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahmetb @codecov-io @rlenferink @nikhita @googlebot