Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: post-migration updates #167

Merged
merged 2 commits into from
Apr 1, 2019
Merged

README: post-migration updates #167

merged 2 commits into from
Apr 1, 2019

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Apr 1, 2019

  • remove "Google project" indication
  • add notice about where to file bugs
  • add communication channels of SIG CLI
  • add link to Kubernetes CoC.

@ahmetb
README: post-migration updates
c326e1e 
- remove "Google project" indication
- add notice about where to file bugs
- add communication channels of SIG CLI
- add link to Kubernetes CoC.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2019
@codecov-io
Copy link

codecov-io commented Apr 1, 2019 •
edited

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   50.91%   50.91%           
=======================================
  Files          13       13           
  Lines         711      711           
=======================================
  Hits          362      362           
  Misses        297      297           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4ffe9...347926c. Read the comment docs.

@ahmetb
Copy link
Member Author

ahmetb commented Apr 1, 2019

curious if I can self approve this
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@ahmetb: you cannot LGTM your own PR.

In response to this:

curious if I can self approve this
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmetb
Copy link
Member Author

ahmetb commented Apr 1, 2019

haha I guessed so

nikhita
nikhita approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2019
@nikhita
Copy link
Member

nikhita commented Apr 1, 2019

@ahmetb you should be able to approve. can you try again?

@nikhita
Copy link
Member

nikhita commented Apr 1, 2019

This looks fishy #167 (comment) O_o

@ahmetb
Copy link
Member Author

ahmetb commented Apr 1, 2019

@nikhita I think I didn't accept the org invite earlier.

@ahmetb
Copy link
Member Author

ahmetb commented Apr 1, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2019
@nikhita
Copy link
Member

nikhita commented Apr 1, 2019

Oh :)

@ahmetb
small fix
347926c 
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2019
@nikhita
Copy link
Member

nikhita commented Apr 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit a276eba into kubernetes-sigs:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmetb @codecov-io @k8s-ci-robot @nikhita