Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch imports to sigs.k8s.io/krew #181

Merged
merged 2 commits into from
May 9, 2019

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented May 9, 2019

/assign @ahmetb

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2019
@corneliusweig
Copy link
Contributor

@soltysh There are quite a few references to the github.com/kubernetes-sigs/krew repo left.
I think this is also the reason why travis fails, because it still says

go_import_path: github.com/kubernetes-sigs/krew

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #181 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   50.91%   50.91%           
=======================================
  Files          13       13           
  Lines         711      711           
=======================================
  Hits          362      362           
  Misses        297      297           
  Partials       52       52
Impacted Files Coverage Δ
pkg/environment/environment.go 77.27% <ø> (ø) ⬆️
cmd/validate-krew-manifest/main.go 37.63% <ø> (ø) ⬆️
pkg/installation/util.go 61.25% <ø> (ø) ⬆️
pkg/installation/move.go 32.55% <ø> (ø) ⬆️
pkg/installation/install.go 35.16% <ø> (ø) ⬆️
pkg/installation/upgrade.go 0% <ø> (ø) ⬆️
pkg/index/indexscanner/scanner.go 67.34% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17c577...80b6485. Read the comment docs.

@ahmetb
Copy link
Member

ahmetb commented May 9, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 59d76f3 into kubernetes-sigs:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants