Rename krew remove to krew uninstall
#189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inverse of `install` is `uninstall`, so this commit renames `krew remove` to `krew uninstall`, and makes `krew remove` an alias to `krew uninstall`.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 50.91% 50.91%
=======================================
Files 13 13
Lines 711 711
=======================================
Hits 362 362
Misses 297 297
Partials 52 52
Continue to review full report at Codecov.
|
corneliusweig
approved these changes
May 29, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, superbrothers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inverse of
installisuninstall, so this PR renameskrew removeto
krew uninstall, and makeskrew removean alias tokrew uninstall./close #188