Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete head field from plugin manifest #212

Merged
merged 5 commits into from
Jun 18, 2019

Conversation

corneliusweig
Copy link
Contributor

@corneliusweig corneliusweig commented Jun 11, 2019

Close #152

Once a new krew version with this PR is released, the head fields in all krew-index plugin yamls can be removed. Luckily, no plugin exclusively relies on the head field and all manifests also have the url set.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 11, 2019
@codecov-io
Copy link

codecov-io commented Jun 11, 2019

Codecov Report

Merging #212 into master will increase coverage by 0.57%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   53.77%   54.35%   +0.57%     
==========================================
  Files          13       13              
  Lines         716      701      -15     
==========================================
- Hits          385      381       -4     
+ Misses        279      269      -10     
+ Partials       52       51       -1
Impacted Files Coverage Δ
pkg/installation/upgrade.go 0% <0%> (ø) ⬆️
pkg/installation/install.go 36.36% <0%> (+1.19%) ⬆️
pkg/installation/util.go 60.81% <100%> (-0.44%) ⬇️
pkg/index/validate.go 94.44% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a9ad7...890f43d. Read the comment docs.

@ahmetb
Copy link
Member

ahmetb commented Jun 18, 2019

Looks excellent, thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8f3656f into kubernetes-sigs:master Jun 18, 2019
@corneliusweig corneliusweig deleted the w/strip-head branch June 18, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: deprecate "head" field
4 participants