Cleanup some TODOs #218
Cleanup some TODOs #218
Conversation
ahmetb
commented
Jun 19, 2019
ahmetb
commented
- cleaned up some obsolete todos (ref: Remove obsolete TODO items #213), some still relevant
- removed PluginIndex type, as it wasn't used for any reason
- cleaned up some obsolete todos (ref: kubernetes-sigs#213), some still relevant - removed PluginIndex type, as it wasn't used for any reason Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
k8s-ci-robot
added
cncf-cla: yes
|
/assign @corneliusweig |
|
@ahmetb: GitHub didn't allow me to assign the following users: corneliusweig. Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=========================================
Coverage ? 53.78%
=========================================
Files ? 14
Lines ? 701
Branches ? 0
=========================================
Hits ? 377
Misses ? 273
Partials ? 51
Continue to review full report at Codecov.
|
pkg/index/types.go
Outdated
| @@ -38,7 +37,8 @@ type PluginSpec struct { | |||
| Platforms []Platform `json:"platforms,omitempty"` | |||
| } | |||
|
|
|||
| // Platform TODO(lbb) | |||
| // Platform describes the how to match to a particular platform (os, arch) and | |||
There was a problem hiding this comment.
I find that comment easier to read, if it is reversed, like so:
// Platform describes how to perform an installation on a specific platform
// and how to match the target platform (os, arch).
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@corneliusweig: changing LGTM is restricted to assignees, and only kubernetes-sigs/krew repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/shrug |
|
/shrug cancel |
Note: trying github's code review suggestions feature. Might cause CLA check to break. Co-Authored-By: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
Merging manually since approved manually. |
