-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack: move out install_kubectl_if_needed #220
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @corneliusweig |
@ahmetb: GitHub didn't allow me to assign the following users: corneliusweig. Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but needs small adjustments.
- install appropriate kubectl (goos/goarch) - save it to $GOPATH/bin since "export $PATH" won't work outside a particular script - lowercase naming for local variables Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 54.35% 54.35%
=======================================
Files 13 13
Lines 701 701
=======================================
Hits 381 381
Misses 269 269
Partials 51 51 Continue to review full report at Codecov.
|
I'll go ahead and merge this since @corneliusweig approved. |
script
Fixes #210.