hack: update verify-code-patterns.sh

[ahmetb]

This fixes an issue where sometimes bash returns 1 instead of 123
in the exitcode of the pipe. This simplifies the find|xargs|grep with
just grep.

Fixes #217
/assign @corneliusweig

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[corneliusweig]

The output looks great and it's much simpler like that!

One of the options needs to be adjusted (at least on my system).

[ahmetb]

One of the options needs to be adjusted (at least on my system).

Does it work if I say --exclude 'vendor/*'? I hope it's not BSD grep vs GNU grep difference?

[corneliusweig]

No, --exclude 'vendor/*' or similar does unfortunately not work. My man page says:

--exclude=GLOB
Skip any command-line file with a name suffix that matches the pattern GLOB, using
wildcard matching; a name suffix is either the whole name, or any suffix starting
after a / and before a +non-/. When searching recursively, skip any subfile whose
base name matches GLOB; the base name is the part after the last /. A pattern can
use *, ?, and [...] as wildcards, and \ to quote a wildcard or backslash
character literally.

So it's clearly limited to the basename.

---

For completeness:

--exclude-dir=GLOB
Skip any command-line directory with a name suffix that matches the pattern GLOB.
When searching recursively, skip any subdirectory whose base name matches GLOB.
Ignore any redundant trailing slashes in GLOB.

[ahmetb]

Yeah makes sense. I'll fix.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@4b0255c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #221   +/-   ##
=========================================
  Coverage          ?   53.78%           
=========================================
  Files             ?       14           
  Lines             ?      701           
  Branches          ?        0           
=========================================
  Hits              ?      377           
  Misses            ?      273           
  Partials          ?       51

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0255c...8754518. Read the comment docs.