Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes to integration tests #228

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Various fixes to integration tests #228

merged 2 commits into from
Jun 27, 2019

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Jun 27, 2019 •
edited

I was hoping to write more integration tets, but along the way I noticed some
issues with how we run integration tests.
This PR addressses few things about the integration tests that bugged me.

  • do not actually run the test plugin, it's out of our tool's scope
  • run only integration tests from the script (previously ./...)
  • DO NOT use the host-krew, require KREW_BINARY to be set (we almost never want to use host-krew)

Fixes #224
Fixes #225
Fixes #227

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2019
@ahmetb ahmetb force-pushed the integration-tests-fix branch 2 times, most recently from 0164c46 to 9267a0d Compare June 27, 2019 18:26
@codecov-io
Copy link

codecov-io commented Jun 27, 2019 •
edited

Codecov Report

Merging #228 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   53.78%   53.78%           
=======================================
  Files          14       14           
  Lines         701      701           
=======================================
  Hits          377      377           
  Misses        273      273           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76cbc8c...65e22a2. Read the comment docs.

@ahmetb
Various fixes to integration tests
6d73d53 
I fixed a few things about the integration tests that bugged me a litle bit.

- do not actually run the test plugin, it's out of our tool's scope
- run only integration tests from the script (previously ./...)
- use the installed krew when host-krew is present

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
corneliusweig
corneliusweig suggested changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@corneliusweig corneliusweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement of the integration test setup. Just some smaller nits.

hack/run-integration-tests.sh Outdated Show resolved Hide resolved
test/krew/krew.go Show resolved Hide resolved
test/krew/krew.go Outdated Show resolved Hide resolved
test/krew/krew.go Outdated Show resolved Hide resolved
test/krew/krew.go Show resolved Hide resolved
test/krew/krew.go Outdated Show resolved Hide resolved
test/krew/krew.go Show resolved Hide resolved
test/krew_test.go Show resolved Hide resolved
@ahmetb
Address code review feedback
65e22a2 
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb
Copy link
Member Author

ahmetb commented Jun 27, 2019

Addressed code review feedback. 👍 Thanks!

@corneliusweig
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@corneliusweig: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@corneliusweig
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmetb
Copy link
Member Author

ahmetb commented Jun 27, 2019

🔜

@ahmetb ahmetb merged commit bca4cde into kubernetes-sigs:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusweig corneliusweig corneliusweig requested changes

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@ahmetb @codecov-io @corneliusweig @k8s-ci-robot