Ensure that go modules are enabled in all helper scripts #243
Conversation
This ensures that they can be run individually.
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
======================================
Coverage 53.6% 53.6%
======================================
Files 16 16
Lines 735 735
======================================
Hits 394 394
Misses 289 289
Partials 52 52Continue to review full report at Codecov.
|
k8s-ci-robot
added
size/S
| @@ -47,4 +47,4 @@ fi | |||
| KREW_BINARY="${krew_binary_realpath}" | |||
| export KREW_BINARY | |||
|
|
|||
| go test -test.v sigs.k8s.io/krew/integration_test | |||
| GO111MODULE=on go test -test.v sigs.k8s.io/krew/integration_test | |||
There was a problem hiding this comment.
I’d use “env A=B cmd” but in this case it makes no difference.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before, these scripts failed on my system when run individually.