Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output of krew search easier to read #253

Merged

Conversation

corneliusweig
Copy link
Contributor

@corneliusweig corneliusweig commented Jul 12, 2019

So far, the last column was labelled with STATUS and had three options
(installed, available, unavailable). This was hard to read because
installed and available have the same length, and unavailable was not
specific.

Now, the column is labelled INSTALLED with values
yes/no/unavailable on <PLATFORM>

In addition, I increased the padding between columns to two spaces which looks cleaner. WDYT?


Sample output:

NAME                            DESCRIPTION                                         INSTALLED
access-matrix                   Show an access matrix for server resources          no
bulk-action                     Do bulk actions on Kubernetes resources.            unavailable on linux
ca-cert                         Print the PEM CA certificate of the current clu...  yes

Fix #250

So far, the last column was labelled with `STATUS` and had three options
(installed, available, unavailable). This was hard to read because
installed and available have the same length, and `unavailable` was not
specific.

Now, the column is labelled `INSTALLED` with values
yes/no/unavailable on <PLATFORM>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 12, 2019
@codecov-io
Copy link

codecov-io commented Jul 12, 2019

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #253   +/-   ##
======================================
  Coverage    53.6%   53.6%           
======================================
  Files          16      16           
  Lines         735     735           
======================================
  Hits          394     394           
  Misses        289     289           
  Partials       52      52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 328fc71...dcc8037. Read the comment docs.

@ahmetb
Copy link
Member

ahmetb commented Jul 12, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fa7f844 into kubernetes-sigs:master Jul 12, 2019
@corneliusweig corneliusweig deleted the w/list-installed-column branch July 12, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status column in krew search is hard to read
4 participants