-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack: add script to verify receipts migration #255
hack: add script to verify receipts migration #255
Conversation
a52b118
to
5893820
Compare
This comment has been minimized.
This comment has been minimized.
5893820
to
de06577
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great idea to test the migration in this way!
The script is a thorough piece of art. I could only find small nits.
c498abc
to
8f39524
Compare
/hold cancel |
I couldn't think of any additional test cases, so I threw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more questions, then this can be merged.
/retest |
8f39524
to
aea8842
Compare
This script makes sure as long as we have the 'system receipts-upgrade' command upgrades from krew v0.2.1 to the currently built version works. This should be deleted once the 'system receipts-upgrade' command is gone. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
aea8842
to
2479673
Compare
Looks like doing |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This script makes sure as long as we have the 'system receipts-upgrade' command
upgrades from krew v0.2.1 to the currently built version works.
This should be deleted once the 'system receipts-upgrade' command is gone.
/hold
rebase + merge after #249 (tests expected to fail until then)