Add --no-update-index option to bypass updates #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 55.07% 55.34% +0.26%
==========================================
Files 19 19
Lines 877 880 +3
==========================================
+ Hits 483 487 +4
+ Misses 341 337 -4
- Partials 53 56 +3
Continue to review full report at Codecov.
|
corneliusweig
suggested changes
Jul 21, 2019
| glog.V(4).Infof("--manifest specified, not ensuring plugin index") | ||
| return nil | ||
| if *noUpdateIndex { | ||
| glog.V(4).Infof("--no-update-index specified, skipping updating local copy of plugin index") |
There was a problem hiding this comment.
This is missing a return nil here.
This option added to 'install' and 'upgrade' sub-commands allows users
(primarily developers) to test behavior locally (such as upgrades) while
preventing krew from auto-{updating,reverting,resetting} changes to the
local copy of the index repository at $KREW_ROOT/index.
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
ahmetb
force-pushed
the
bypass-auto-index-update
branch
from
14a56a4
to
88fec4a
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option added to 'install' and 'upgrade' sub-commands allows users
(primarily developers) to test behavior locally (such as upgrades) while
preventing krew from auto-{updating,reverting,resetting} changes to the
local copy of the index repository at $KREW_ROOT/index.
Introducing this flag as "experimental", this way we can delete it if we don't
like it in the future. It's provided as an "escape hatch". An alternative I
can think of is a file like
$dir/.noupdateexisting in the index repo, butI think this is cleaner.
Two issues that are in my mind currently wrt this change:
I can't recide between
--no-update-indexvs--no-index-update. In ourgcloudconventions we tend to use--no-$VERB-$NOUNso I'm going withthis.
Writing integration tests currently sound unnecessary to me, although it's
probably possible (we can write files to the per-test index dir, and see if
they survive krew upgrade and krew install, which don't have to succeed).
Thoughts?
Fixes #263.