test: remove -v from tests #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-v is only useful if you want to see all the test cases that are being run. I don't think this is useful locally or in the build system. I've been having trouble scrolling a lot and trying to find the FAIL: line. Any failed test will still print its t.Log or stdout/stderr printing along with the test method name, so this should be fine. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=======================================
Coverage 54.84% 54.84%
=======================================
Files 19 19
Lines 877 877
=======================================
Hits 481 481
Misses 342 342
Partials 54 54Continue to review full report at Codecov.
|
|
Yeah, makes sense. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-v is only useful if you want to see all the test cases that are being run.
I don't think this is useful locally or in the build system. I've been having
trouble scrolling a lot and trying to find the FAIL: line.
Any failed test will still print its t.Log or stdout/stderr printing along with
the test method name, so this should be fine.
/assign @corneliusweig
/kind cleanup