pkg/installation: cleanup refactoring #296
Conversation
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
approved
- `getDownloadTarget()`: removed, it didn't do anything interesting.
- `downloadAndMove()`:
- renamed to `downloadAndExtract()` which better reflects the functionality
- reduced methods from 7 to 4
- refactored the "move" operation out of this method (decouples "move"
from "download+extract") and we now call "move" from install().
- added unit tests (both for downloading a file, and --archive override)
- introduced `installOperation` which contains the minimal information to
perform installation operation.
- introduced `InstallOpts` type to scale out (in the future)
- `install()`:
- accepts fewer arguments (2) than before (8)
- no longer knows about index.Plugin, or environment.Paths
- cmd/install: removed a redundant check detecting specifying plugin names
along with --manifest option.
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
- Coverage 56.22% 55.04% -1.18%
==========================================
Files 19 19
Lines 891 901 +10
==========================================
- Hits 501 496 -5
- Misses 337 353 +16
+ Partials 53 52 -1
Continue to review full report at Codecov.
|
| return errors.Wrap(err, "failed while moving files to the installation directory") | ||
| } | ||
|
|
||
| subPathAbs, err := filepath.Abs(op.installDir) |
There was a problem hiding this comment.
Could you extract the whole sub-path checking logic to a separate function?
There was a problem hiding this comment.
Can we do that in another PR? 😄
Yeah, I think |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
getDownloadTarget(): removed, it didn't do anything interesting.downloadAndMove():downloadAndExtract()which better reflects the functionalityfrom "download+extract") and we now call "move" from install().
introduced
installOperationwhich contains the minimal information toperform installation operation.
introduced
InstallOptstype to scale out (in the future)install():cmd/install: removed a redundant check detecting specifying plugin names
along with --manifest option.
Fixes #293
/kind cleanup
/assign @corneliusweig