Validate plugins can be removed without local manifest #300
Conversation
This validates the scenario that we can remove/rename plugins in the index without breaking local user installations (since this is now possible with the install receipts). Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
=======================================
Coverage 55.66% 55.66%
=======================================
Files 19 19
Lines 918 918
=======================================
Hits 511 511
Misses 355 355
Partials 52 52Continue to review full report at Codecov.
|
| defer cleanup() | ||
|
|
||
| test = test.WithIndex() | ||
| localManifest := filepath.Join(test.Root(), "index", "plugins", validPlugin+constants.ManifestExtension) |
There was a problem hiding this comment.
I'm a bit unhappy that we depend on the implementation detail of where the manifest is stored. It would be cleaner to use environment.Paths here. Maybe it's time to refactor the environment package, so that it can be used without setting up env variables.
There was a problem hiding this comment.
Honestly I agree, but we'd immediately know when we change the paths because the test would start breaking.
There was a problem hiding this comment.
That said I think we can expose NewPaths() here that doesn't rely on environment variables, for testing or other purposes:
There was a problem hiding this comment.
Ok, let's do that in another PR and close this one. I think there are more locations which can be made simpler.
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This validates the scenario that we can remove/rename plugins in the index
without breaking local user installations (since this is now possible with
the install receipts).
/assign @corneliusweig