Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index revision to plugin overview page #307

Merged

Conversation

corneliusweig
Copy link
Contributor

When resolving the index revision, be careful to always report a commit sha and not branch names.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2019
@codecov-io
Copy link

codecov-io commented Aug 18, 2019

Codecov Report

Merging #307 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files          19       19           
  Lines         918      918           
=======================================
  Hits          511      511           
  Misses        355      355           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739c312...edd44d0. Read the comment docs.

The following kubectl plugins are currently available
on [Krew plugin index](https://sigs.k8s.io/krew-index).
The following kubectl plugins are available on
[Krew plugin index](https://sigs.k8s.io/krew-index) as of revision %s.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think most users care about commit numbers.
Do you think this will serve a good purpose? Instead we can just tell them “run this command for the most up-to-date list”.

@corneliusweig
Copy link
Contributor Author

Hmm 🤔, I agree that the exact commit number is not so important. But I also don't think that any user would run our page generator.

Basically, what needs to come across is that the page may be outdated. We can also add such a note without mentioning the commit number. But I thought in the current way a user can determine what has happened since last generating that overview page.

@ahmetb
Copy link
Member

ahmetb commented Aug 19, 2019

But I thought in the current way a user can determine what has happened since last generating that overview page.

For that to happen I think we actually need to link to plugins/ directory at that revision, and at the HEAD. I don't think anyone is realistically going to diff the two revisions.

So I recommend maybe we can just say:

for the most up-to-date list of plugins, visit krew-index repository or run kubectl krew search

wdyt?

@corneliusweig
Copy link
Contributor Author

So I recommend maybe we can just say:

for the most up-to-date list of plugins, visit krew-index repository or run kubectl krew search

wdyt?

Ok with me. I'll update the PRs

@ahmetb
Copy link
Member

ahmetb commented Aug 20, 2019

Reminder to push updates here as well.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2019
@corneliusweig
Copy link
Contributor Author

Reminder to push updates here as well.

Sorry, that slipped through. I thought I had done that. Can you take a look?

@ahmetb
Copy link
Member

ahmetb commented Aug 21, 2019

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 82e6899 into kubernetes-sigs:master Aug 21, 2019
@corneliusweig corneliusweig deleted the w/plugin-overview-version branch August 21, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants