-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add index revision to plugin overview page #307
Add index revision to plugin overview page #307
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 55.66% 55.66%
=======================================
Files 19 19
Lines 918 918
=======================================
Hits 511 511
Misses 355 355
Partials 52 52 Continue to review full report at Codecov.
|
The following kubectl plugins are currently available | ||
on [Krew plugin index](https://sigs.k8s.io/krew-index). | ||
The following kubectl plugins are available on | ||
[Krew plugin index](https://sigs.k8s.io/krew-index) as of revision %s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think most users care about commit numbers.
Do you think this will serve a good purpose? Instead we can just tell them “run this command for the most up-to-date list”.
Hmm 🤔, I agree that the exact commit number is not so important. But I also don't think that any user would run our page generator. Basically, what needs to come across is that the page may be outdated. We can also add such a note without mentioning the commit number. But I thought in the current way a user can determine what has happened since last generating that overview page. |
For that to happen I think we actually need to link to plugins/ directory at that revision, and at the HEAD. I don't think anyone is realistically going to diff the two revisions. So I recommend maybe we can just say:
wdyt? |
Ok with me. I'll update the PRs |
Reminder to push updates here as well. |
6899753
to
edd44d0
Compare
Sorry, that slipped through. I thought I had done that. Can you take a look? |
/lgtm |
When resolving the index revision, be careful to always report a commit sha and not branch names.