Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: make test config explicit #320

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

ferhatelmas
Copy link
Contributor

@ferhatelmas ferhatelmas commented Aug 26, 2019

follow up on #318

addresses the request from this comment by explicitly including test files into lint

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2019
@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #320   +/-   ##
======================================
  Coverage    57.3%   57.3%           
======================================
  Files          19      19           
  Lines         904     904           
======================================
  Hits          518     518           
  Misses        335     335           
  Partials       51      51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a3885...06fa900. Read the comment docs.

@corneliusweig
Copy link
Contributor

This setting is true by default (see https://github.com/golangci/golangci-lint/blob/d2b1eea2c6171a1a1141a448a745335ce2e928a1/.golangci.example.yml#L16). Is there a particular reason why you want to make that explicit?

@ferhatelmas
Copy link
Contributor Author

Yes, it's true by default but as in the linked comment, @ahmetb suggested to make it explicit unless hurts.

@corneliusweig
Copy link
Contributor

Hmm.. if either of you feel strongly about making this explicit, I won't say no. But it feels a bit redundant.

@ahmetb
Copy link
Member

ahmetb commented Aug 26, 2019

I think it's fine, if someday the default changes, we're shielded.

/lgtm
/approve
thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit dbfcd95 into kubernetes-sigs:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants