lint: enable errcheck and fix some issues #327

ferhatelmas · 2019-09-02T00:04:24Z

add .errcheck-excluded.txt to disable some function calls as an example
fixes Consider enabling errcheck linter #325

* add .errcheck-excluded.txt to disable some function calls * related to kubernetes-sigs#325

ferhatelmas · 2019-09-02T00:07:05Z

I had added fixes keyword but it seems not allowed so changed it to related to.

codecov-io · 2019-09-02T00:08:15Z

Codecov Report

Merging #327 into master will decrease coverage by 0.41%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage    57.3%   56.89%   -0.42%     
==========================================
  Files          19       19              
  Lines         904      907       +3     
==========================================
- Hits          518      516       -2     
- Misses        335      338       +3     
- Partials       51       53       +2

Impacted Files	Coverage Δ
pkg/download/downloader.go	`65.71% <0%> (-1.6%)`	⬇️
cmd/validate-krew-manifest/main.go	`56.12% <0%> (-2.22%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798fe49...9ee6a54. Read the comment docs.

ahmetb · 2019-09-02T16:48:26Z

cmd/validate-krew-manifest/main.go

-	flag.Set("logtostderr", "true") // Set glog default to stderr
+	// Set glog default to stderr
+	if err := flag.Set("logtostderr", "true"); err != nil {
+		glog.Fatal(err)


I think it would be good to use fmt.Printf + os.Exit(1) here, as glog is currently not initialized probably.

updated as suggested.

cmd/krew/cmd/root.go

corneliusweig · 2019-09-02T18:31:57Z

Looks good to me. Thanks for getting this done!

Have you tried changing the PR description from "related to #325" to "fixes #325"? I think it's only forbidden in commit messages but fine in PR descriptions.

corneliusweig

Looking at this a little more, I do not understand why some errors are not reported. For example, in pkg/receiptsmigration/migration_test.go:66 there is a Setenv call which returns an unhandled error that is not reported. On the other hand, the unhandled MkdirAll error in line 72 is reported. So what is the logic behind reporting some but not all errors?

corneliusweig · 2019-09-02T18:37:35Z

.errcheck-excluded.txt

@@ -0,0 +1,2 @@
+os.MkdirAll


Would it also be possible to explicitly ignore errors in the exact locations where we want to ignore errors. Like so:

_ = os.MkdirAll(...)

definitely. Then we shouldn't have this file for the sake of being explicit all the time.

yes, it's possible. For being explicit, I dropped this file.

ferhatelmas · 2019-09-03T17:46:19Z

I think it's only forbidden in commit messages but fine in PR descriptions.

@corneliusweig updated and seems so. Thanks!

ahmetb · 2019-09-03T17:56:26Z

.errcheck-excluded.txt

@@ -0,0 +1,2 @@
+os.MkdirAll


since it's just 2 lines or possibly even 1, let's just drop this file if possible and call errcheck with --flags. it's kinda annoying to have an extra file in repo root just for this.

yes, dropped. Will push soon.

ferhatelmas · 2019-09-03T18:17:33Z

Looking at this a little more, I do not understand why some errors are not reported. For example, in pkg/receiptsmigration/migration_test.go:66 there is a Setenv call which returns an unhandled error that is not reported. On the other hand, the unhandled MkdirAll error in line 72 is reported. So what is the logic behind reporting some but not all errors?

It seems a bug from golangci-lint. Even if errcheck reports it, golangci-lint doesn't report it. Reported at golangci/golangci-lint#657

corneliusweig · 2019-09-03T19:00:21Z

/lgtm
waiting for @ahmetb to approve.

ahmetb · 2019-09-03T19:05:43Z

/approve

k8s-ci-robot · 2019-09-03T19:05:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahmetb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 2, 2019

k8s-ci-robot requested review from juanvallejo and soltysh September 2, 2019 00:04

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2019

lint: enable errcheck and fix some issues

c066971

* add .errcheck-excluded.txt to disable some function calls * related to kubernetes-sigs#325

ferhatelmas force-pushed the enable-errcheck branch from 16da45d to c066971 Compare September 2, 2019 00:06

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 2, 2019

ahmetb reviewed Sep 2, 2019

View reviewed changes

cmd/krew/cmd/root.go Show resolved Hide resolved

corneliusweig suggested changes Sep 2, 2019

View reviewed changes

ahmetb reviewed Sep 3, 2019

View reviewed changes

drop ignore file and be more explicit

9ee6a54

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2019

k8s-ci-robot assigned corneliusweig Sep 3, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2019

k8s-ci-robot merged commit f7a36f5 into kubernetes-sigs:master Sep 3, 2019

ferhatelmas deleted the enable-errcheck branch September 5, 2019 18:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lint: enable errcheck and fix some issues #327

lint: enable errcheck and fix some issues #327

ferhatelmas commented Sep 2, 2019 •

edited

Loading

ferhatelmas commented Sep 2, 2019

codecov-io commented Sep 2, 2019 •

edited

Loading

ahmetb Sep 2, 2019 •

edited

Loading

ferhatelmas Sep 3, 2019

corneliusweig commented Sep 2, 2019

corneliusweig left a comment •

edited

Loading

corneliusweig Sep 2, 2019

ferhatelmas Sep 3, 2019 •

edited

Loading

ferhatelmas Sep 3, 2019

ferhatelmas commented Sep 3, 2019 •

edited

Loading

ahmetb Sep 3, 2019

ferhatelmas Sep 3, 2019

ferhatelmas Sep 3, 2019

ferhatelmas commented Sep 3, 2019 •

edited

Loading

corneliusweig commented Sep 3, 2019

ahmetb commented Sep 3, 2019

k8s-ci-robot commented Sep 3, 2019

lint: enable errcheck and fix some issues #327

lint: enable errcheck and fix some issues #327

Conversation

ferhatelmas commented Sep 2, 2019 • edited Loading

ferhatelmas commented Sep 2, 2019

codecov-io commented Sep 2, 2019 • edited Loading

Codecov Report

ahmetb Sep 2, 2019 • edited Loading

Choose a reason for hiding this comment

ferhatelmas Sep 3, 2019

Choose a reason for hiding this comment

corneliusweig commented Sep 2, 2019

corneliusweig left a comment • edited Loading

Choose a reason for hiding this comment

corneliusweig Sep 2, 2019

Choose a reason for hiding this comment

ferhatelmas Sep 3, 2019 • edited Loading

Choose a reason for hiding this comment

ferhatelmas Sep 3, 2019

Choose a reason for hiding this comment

ferhatelmas commented Sep 3, 2019 • edited Loading

ahmetb Sep 3, 2019

Choose a reason for hiding this comment

ferhatelmas Sep 3, 2019

Choose a reason for hiding this comment

ferhatelmas Sep 3, 2019

Choose a reason for hiding this comment

ferhatelmas commented Sep 3, 2019 • edited Loading

corneliusweig commented Sep 3, 2019

ahmetb commented Sep 3, 2019

k8s-ci-robot commented Sep 3, 2019

ferhatelmas commented Sep 2, 2019 •

edited

Loading

codecov-io commented Sep 2, 2019 •

edited

Loading

ahmetb Sep 2, 2019 •

edited

Loading

corneliusweig left a comment •

edited

Loading

ferhatelmas Sep 3, 2019 •

edited

Loading

ferhatelmas commented Sep 3, 2019 •

edited

Loading

ferhatelmas commented Sep 3, 2019 •

edited

Loading