Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling when no matching platform is found #345

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

corneliusweig
Copy link
Contributor

err is nil here, so errors.Wrapf(...) is nil too, and that the calling code assumes that no error happened.

Fix #344

`err` is nil here, so errors.Wrapf(...) is nil too, so that the
calling code assumes that no error happened.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2019
@codecov-io
Copy link

codecov-io commented Sep 23, 2019

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files          19       19           
  Lines         907      907           
=======================================
  Hits          515      515           
  Misses        339      339           
  Partials       53       53
Impacted Files Coverage Δ
pkg/installation/install.go 42.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641920a...dfed99d. Read the comment docs.

@ahmetb
Copy link
Member

ahmetb commented Sep 24, 2019

/lgtm
/approve

Up to you to make a patch release or not.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e88f854 into kubernetes-sigs:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

krew install fails to print error when no selector matches
4 participants