Remove sub go.mod from cmd

[ferhatelmas]

remove cmd/* gomod since they don't bring the benefits they were supposed to bring.

context of how it was realized: #422 (comment)

[ahmetb]

Actually it helps us split dependencies between krew and these tools. It’s not the worst idea to keep these.

[corneliusweig]

Interesting. Our linter doesn't find this issue when the go.{mod,sum} files in the submodule are present.

I think the biggest reason for removing the submodule is that we don't need to bother about keeping the krew version in sync with the main module there. However, we could also achieve that with a replace directive in go.mod.

On the other hand, it's nice that we can add dependencies to the submodules without poisoning the main krew module.

---

Overall, I'm slightly in favor of keeping the status quo. Just because it improves the separation of krew and its associated utils. But I'm open for other improvements which reduce the maintenance overhead.

[ahmetb]

Technically, the go.mod at the root should be requiring more pkgs now that the child go.mod's are deleted. But I don't see that happening, weird.

I feel like within travis it might be editing go.mod (during go mod download, or go test ./...). I wish we could easily globally set -mod=readonly, so we don't add new deps on the fly.

[ahmetb]

I guess indeed these two tools don't really add new deps to Krew.
So let's go ahead with this.

[ferhatelmas]

Our linter doesn't find this issue when the go.{mod,sum} files in the submodule are present.

Following is from go modules wiki:

go test ./... from the repository root will no longer test everything in the repository

Similarly, go/analysis (underlying package leveraged by golangci-lint) stops too when ./... is used or target is left out.

we could also achieve that with a replace directive in go.mod.

Still, for a release, it needs a version bump.

I guess indeed these two tools don't really add new deps to Krew.

Exactly.

So let's go ahead with this.

Sounds good, I will check what is failing.

[ahmetb]

cmd/generate-plugin-overview/generate-plugin-overview.go:111:2: ifElseChain: rewrite if-else to switch statement (gocritic)
	if matches := githubRepoPattern.FindStringSubmatch(homepage); matches != nil {
	^

stuff like these are intrusive. if we can disable these sometime, I really appreciate. It does the same for simple slice allocations without count specified, there's like no point.

[ferhatelmas]

if we can disable these sometime, I really appreciate. It does the same for simple slice allocations without count specified, there's like no point.

Ok, I will make a separate pass for it.

[codecov-io]

Codecov Report

Merging #424 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #424   +/-   ##
=======================================
  Coverage   56.41%   56.41%           
=======================================
  Files          19       19           
  Lines         927      927           
=======================================
  Hits          523      523           
  Misses        349      349           
  Partials       55       55

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1c7f7...57b0880. Read the comment docs.

[ahmetb]

/lgtm
/approve

can you please make sure krew-index CI still works in terms of fetching these tools?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[corneliusweig]

we could also achieve that with a replace directive in go.mod.

Still, for a release, it needs a version bump.

Mental note: need to understand this better.

[ahmetb]

Also I think the replace directives are meant to be checked in only if they are used to "strictly pin" to a strict commit of a dependency.

Stuff like replace sigs.k8s.io => ../.. should not be checked in if the module is being go-get'ed (like these cmd/* tools).

[ferhatelmas]

can you please make sure krew-index CI still works in terms of fetching these tools?

@ahmetb Looks good.