Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the installation instruction to also run krew update. #430

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

tony-yang
Copy link
Contributor

@tony-yang tony-yang commented Dec 9, 2019

For a fresh install, run krew update to initialize the local plugin index as part of the installation process to avoid the plugin index is not initialized error for first time user.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2019
@tony-yang
Copy link
Contributor Author

/assign @soltysh

@tony-yang
Copy link
Contributor Author

/remove-do-not-merge/invalid-commit-message

@tony-yang
Copy link
Contributor Author

/remove-do-not-merge

@corneliusweig
Copy link
Contributor

@tony-yang Can you remove the Fixes #419 from your commit message and force-push? Otherwise prow will not let us merge this :)

@corneliusweig
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2019
For a fresh install, run krew update to initialize the local plugin index as part of the installation process to avoid the `plugin index is not initialized` error for first time user.
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Dec 10, 2019
@codecov-io

This comment has been minimized.

@tony-yang
Copy link
Contributor Author

Thanks @corneliusweig, originally updated the text in my first comment to remove the FIX # label but didn't realize I need to also remove them from my commit. Force pushed.

@ahmetb
Copy link
Member

ahmetb commented Dec 10, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, tony-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit acc43bf into kubernetes-sigs:master Dec 10, 2019
@tony-yang tony-yang deleted the readme branch December 10, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants