Disallow fmt.Errorf usage through code validation #433
Conversation
Came across during a code review, new contributors can end up using fmt.Errorf which does not create stack trace at the error site --and also doesn't preserve stack trace if used to wrap an error. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 56.35% 56.35%
=======================================
Files 19 19
Lines 928 928
=======================================
Hits 523 523
Misses 350 350
Partials 55 55
Continue to review full report at Codecov.
|
|
Related to #414, when it's done, this should be removed too. |
|
Yeah. We have to wait until Cornelius to come back from vacation to merge things. :) |
|
Huh, holidays? Nah, I was just being slow.. 🎄 🎅 time.. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Came across during a code review, new contributors can end up using fmt.Errorf
which does not create stack trace at the error site --and also doesn't preserve
stack trace if used to wrap an error.