Disable all first then enable needed linters

[ferhatelmas]

First disable all linters then enable what we need. Otherwise, all linters are running then results are filtered. See with -v flag.

Also, sort enabled linters in config.

[codecov-io]

Codecov Report

Merging #439 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #439   +/-   ##
=======================================
  Coverage   56.25%   56.25%           
=======================================
  Files          19       19           
  Lines         928      928           
=======================================
  Hits          522      522           
  Misses        351      351           
  Partials       55       55

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bc0ca...17c1015. Read the comment docs.

[corneliusweig]

I'm not sure I understand what is the problem here. I cannot find any filtering of linter results going on when running with -v.

Besides, I think the enabled linters are correct and some are active by default whereas others are enabled explicitly. Iow, the list of enabled linters in our .golangci.yaml is not exhaustive and does not list what is enabled by default anyways. Does that make sense?

[ferhatelmas]

some are active by default

This is the key part. If we don't disable all first, we might be adding more into already enabled ones or our config is noop. However, if we disable first, then the enable list explicitly specifies what is active.

It's somehow related to silence some linters which are useful in the context of high performant server application, but not in a cli such as predeclared.

[corneliusweig]

Alright. Being explicit about the active linters would be nice.

There is some difference between the 17 active linters in this PR (deadcode errcheck gocritic gofmt goimports golint gosimple interfacer maligned misspell prealloc staticcheck structcheck stylecheck unconvert unparam varcheck) vs. the 21 currently active on master (deadcode errcheck gocritic gofmt goimports golint gosimple govet ineffassign interfacer maligned misspell prealloc staticcheck structcheck stylecheck typecheck unconvert unparam unused varcheck). Would you care to clarify why you want to disable those four linters?

[ferhatelmas]

It's somehow related to silence some linters which are useful in the context of high performant server application, but not in a cli such as predeclared.

Sorry for the typo, I had meant prealloc, instead of predeclared.

[ferhatelmas]

Would you care to clarify why you want to disable those four linters?

Sure, actually my intention was to be explicit and then disable one by one with a discussion.

For this goal to happen, I need to ensure that active linter list isn't modified in this PR. Let me update. However, I won't enable typecheck because it's already covered by tests.

[ahmetb]

/lgtm
/approve
Let's give it a try.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment