Fix upgrade if a plugin installed from manifest #458
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 56.47% 56.52% +0.04%
==========================================
Files 19 19
Lines 926 927 +1
==========================================
+ Hits 523 524 +1
Misses 350 350
Partials 53 53
Continue to review full report at Codecov.
|
integration_test/testutil_test.go
Outdated
| validPlugin2 = "mtail" // a plugin in central index with small size | ||
| validPlugin = "konfig" // a plugin in central index with small size | ||
| validPlugin2 = "mtail" // a plugin in central index with small size | ||
| validNonIndexPlugin = "konfig-non-index" // a plugin not in central index with small size |
There was a problem hiding this comment.
instead of doing this let's do this:
- test.WithIndex()
- find konfig.yaml in the index path, delete it
- use upgrade --no-update-index in both
installandupgradecalls in the integration test.
this way:
- you can fake the situation that konfig is not in the index.
- without having to duplicate a testdata file (I really dislike increasing testdata)
There was a problem hiding this comment.
Sounds much better, updated.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusweig, ferhatelmas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
If a plugin isn't in index, upgrade for all doesn't fail anymore.
Also, added an integration test by modifying valid plugin
konfigtokonfig-non-index.Related to #454 problem 1.