-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub workflows #461
Migrate to GitHub workflows #461
Conversation
@RubenBaez in the meanwhile, I've opened this issue suggesting we can move Would you have cycles to do that? I think we can merge that much more comfortably. |
@ahmetb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RubenBaez, this is looking great! Thanks a lot for your work.
The latest version with all-in-one file looks quite clean, I like it. Also maintenance-wise, this looks pretty reasonable.
One last concern that I have is: could we accidentally pick up a malicious action which steals the github token? I have no idea if and how the actions on the marketplace are screened. Is that a relevant concern, or am I just being paranoid?
I'm still curious what @ferhatelmas thinks about the latest version.
Ok, to me this looks quite good now. There are
|
We can remove Codecov altogether, I haven't been finding it super useful to be honest. |
@corneliusweig
I didn't put it in the pipeline. Therefore. If you change your mind. Or then it becomes necessary, I could add that step :) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, alonyb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @alonyb, I have one final request: You seem to follow closely how GH actions evolve. Should you learn that the env variable workaround (https://github.com/kubernetes-sigs/krew/pull/461/files#diff-e9f950f17198d3d5e3122a44230a09b9R32) can be done in a cleaner way (or can be skipped), could you open a follow-up PR for that? |
@corneliusweig |
This PR contains a new pipeline for this project with GitHub Workflows
There are 2 files, one for PUSH/PR and other for release.
PUSH & PR FILE:
RELEASE FILE:
To see logs about the workflow see the fork on my repo here , both config files are included
This PR will help with this #451