Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to sample-cli-plugin in developer guide #466

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

chriskim06
Copy link
Member

Let me know if the wording of this should be changed at all.

Fixes #328

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2020
@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #466 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   56.52%   56.52%           
=======================================
  Files          19       19           
  Lines         927      927           
=======================================
  Hits          524      524           
  Misses        350      350           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1579013...5e9678e. Read the comment docs.

@ahmetb
Copy link
Member

ahmetb commented Jan 17, 2020

I think there are some changes we made to the sample-cli-plugin that aren’t merged still after such a long time. In that case we don’t need to link out until they’re merged.

@chriskim06
Copy link
Member Author

Sounds good, should I just close this?

@ahmetb
Copy link
Member

ahmetb commented Jan 17, 2020

lets keep it open.
I'm thinking a major Developer Guide overhaul. Would be useful to incorporate there perhaps.
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 17, 2020
@ahmetb
Copy link
Member

ahmetb commented Jan 25, 2020

Honestly I think it's ok sample-cli-plugin doesn't mention Krew in this case.
Krew has enough momentum now.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, chriskim06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 45869cd into kubernetes-sigs:master Jan 25, 2020
@chriskim06 chriskim06 deleted the sample-plugin-docs branch February 21, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to sample cli plugin repo
4 participants