Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-integration-tests.sh: pass args down #476

Merged
merged 1 commit into from
Jan 27, 2020
Merged

run-integration-tests.sh: pass args down #476

merged 1 commit into from
Jan 27, 2020

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Jan 27, 2020

  • make this script accept KREW_BINARY for a custom binary path instead of $1
  • pass args ($@) to "go test" so I can do stuff like "-v -run TestXyz"

@ahmetb
run-integration-tests.sh: pass args down
83a3c81 
- make this script accept KREW_BINARY for a custom binary path instead of $1
- pass args ($@) to "go test" so I can do stuff like "-v -run TestXyz"

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2020
@codecov-io
Copy link

codecov-io commented Jan 27, 2020 •
edited

Codecov Report

Merging #476 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   56.52%   56.47%   -0.05%     
==========================================
  Files          19       19              
  Lines         927      926       -1     
==========================================
- Hits          524      523       -1     
  Misses        350      350              
  Partials       53       53
Impacted Files Coverage Δ
internal/environment/environment.go 87.87% <0%> (-0.36%) ⬇️
internal/installation/install.go 42.1% <0%> (-0.32%) ⬇️
internal/installation/upgrade.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b9cdf...83a3c81. Read the comment docs.

@corneliusweig
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 21fa51e into kubernetes-sigs:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@corneliusweig corneliusweig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmetb @codecov-io @corneliusweig @k8s-ci-robot