Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests for showing new/upgradeable plugins #479

Merged

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Jan 28, 2020

Tests when/how we show "New plugins available" and "Upgrades available for
installed plugins".

Adds ~3 seconds to integration tests.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@ahmetb ahmetb force-pushed the index-update-message-tests branch 2 times, most recently from 5958d43 to e6f3178 Compare January 28, 2020 01:46
Copy link
Contributor

@corneliusweig corneliusweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just two questions.

Small footnote: You didn't write a test for when the installed plugin has no upgrade available, so it should not be listed in the output. This case is somewhat covered by unit tests, so we probably don't need it.

integration_test/update_test.go Outdated Show resolved Hide resolved
integration_test/update_test.go Outdated Show resolved Hide resolved
@ahmetb
Copy link
Member Author

ahmetb commented Jan 28, 2020

You didn't write a test for when the installed plugin has no upgrade available, so it should not be listed in the output. This case is somewhat covered by unit tests, so we probably don't need it.

actually that's valid, maybe I'll refactor the 2-plugin installing test to do that.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   56.47%   56.47%           
=======================================
  Files          19       19           
  Lines         926      926           
=======================================
  Hits          523      523           
  Misses        350      350           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fa51e...e638453. Read the comment docs.

@ahmetb
Copy link
Member Author

ahmetb commented Jan 29, 2020

done PTAL.

@corneliusweig
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants