-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration tests for showing new/upgradeable plugins #479
integration tests for showing new/upgradeable plugins #479
Conversation
5958d43
to
e6f3178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just two questions.
Small footnote: You didn't write a test for when the installed plugin has no upgrade available, so it should not be listed in the output. This case is somewhat covered by unit tests, so we probably don't need it.
actually that's valid, maybe I'll refactor the 2-plugin installing test to do that. |
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
e6f3178
to
e638453
Compare
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
=======================================
Coverage 56.47% 56.47%
=======================================
Files 19 19
Lines 926 926
=======================================
Hits 523 523
Misses 350 350
Partials 53 53 Continue to review full report at Codecov.
|
done PTAL. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tests when/how we show "New plugins available" and "Upgrades available for
installed plugins".
Adds ~3 seconds to integration tests.