-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OS/Arch information in the krew version CLI output #484
Conversation
Reference issue: #470 |
/assign @soltysh |
/unassign @soltysh @tony-yang do you mind adding a test to TestKrewVersion* ? |
Sure, will update the PR later |
Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 56.47% 56.47%
=======================================
Files 19 19
Lines 926 926
=======================================
Hits 523 523
Misses 350 350
Partials 53 53 Continue to review full report at Codecov.
|
Hi, @ahmetb I updated the integration test. |
Which assign function are you referring to? |
Hi @tony-yang, |
Thanks Cornelius, good to know. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, tony-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add OS/Arch information in the krew version CLI output to help with diagnostics.
No unit test added since the function we are calling is already well tested.
Updated the KrewVersionTest integration test to convert the stdout to go map to leverage go-cmp for better test assertion. We now can report failure when new output is added to the
krew version
command.Fixes #470