Add pull request template

[corneliusweig]

When small PRs are opened they often contain only very little description about the issue. In particular, they

• don't reference existing issues
• don't set related issues to auto-close
• open PRs without issues

This template should help out to improve this. Also, it explicitly mentions tests, so we hopefully see more of those :)

[codecov-io]

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   56.47%   56.47%           
=======================================
  Files          19       19           
  Lines         926      926           
=======================================
  Hits          523      523           
  Misses        350      350           
  Partials       53       53

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ceeae5...b807c3a. Read the comment docs.

[ahmetb]

I'm -1 b/c it's too long. I don't find the long PR/issue templates productive.

• don't reference existing issues
• don't set related issues to auto-close
• open PRs without issues

If all you're trying to address is these points, this will do:

Fixes #...
Related issue: #...
<!-- For proposed features, make sure there's an issue it's discussed first -->

[corneliusweig]

We can definitely shorten more. Another goal is to remind submitters to add test.

Sooo.. the checklist has become rather short and hard to ignore 😄

[ahmetb]

Lets not do checklists if we can. Not everything warrants a test, and we can easily say please add tests.

[ahmetb]

IMO lets not have any [ ] at all. I don’t want progress bars floating around for no good reason. Most people don’t even know GFM has that feature. If we can cap at 3 consecutive lines and no checkmarks I am happier.

[corneliusweig]

Alright let's keep it minimal then. It's anyway just restating what is in our contributor guidelines.

[ahmetb]

Do you mind removing empty lines. They aren’t required for newlines in PR descriptions.

[corneliusweig]

Right, I should have known 🤣

[ahmetb]

/lgtm
/approve
Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment