Resolve todo and add unit test #488
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
| @@ -72,3 +76,11 @@ func (td *TempDir) Write(file string, content []byte) *TempDir { | |||
| } | |||
| return td | |||
| } | |||
|
|
|||
| func (td *TempDir) WritePlugin(file string, plugin index.Plugin) *TempDir { | |||
There was a problem hiding this comment.
I figure this will be useful if we want to write more tests that involve the filesystem. It may not be the right place though.
There was a problem hiding this comment.
eh, it's ok. i suspect we might forget to use it. :)
There was a problem hiding this comment.
pls add td.t.Helper() and it's lgtm
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
==========================================
+ Coverage 56.47% 57.45% +0.97%
==========================================
Files 19 19
Lines 926 926
==========================================
+ Hits 523 532 +9
+ Misses 350 339 -11
- Partials 53 55 +2
Continue to review full report at Codecov.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related issue: #270