Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logo to docs #500

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Add logo to docs #500

merged 1 commit into from
Feb 11, 2020

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Feb 9, 2020

  • add logo to readme (+repo social preview)
  • create a doc listing logo assets

/cc @iboonox

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2020
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Feb 9, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2020
@codecov-io
Copy link

codecov-io commented Feb 9, 2020 •
edited

Codecov Report

Merging #500 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files          22       22           
  Lines         969      969           
=======================================
  Hits          567      567           
  Misses        346      346           
  Partials       56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f129f...1424982. Read the comment docs.

@ahmetb ahmetb force-pushed the logo-docs branch 2 times, most recently from 54da26a to 218215e Compare February 9, 2020 20:04
@ahmetb
Add logo to docs
1424982 
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
corneliusweig
corneliusweig reviewed Feb 10, 2020
View reviewed changes
README.md
@@ -1,3 +1,6 @@
<img src="assets/logo/horizontal/color/krew-horizontal-color.png" width="480"
alt="Krew logo"/>

# krew
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we still need the heading, if the logo already says "krew".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually still useful for SEO, since it's an h1.

@corneliusweig
Copy link
Contributor

/lgtm
/approve

cc @iboonox This looks so cool! 😎

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5e5b941 into kubernetes-sigs:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusweig corneliusweig corneliusweig left review comments

Assignees

@corneliusweig corneliusweig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmetb @codecov-io @corneliusweig @k8s-ci-robot