Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static URL to download assets from latest release #513

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

corneliusweig
Copy link
Contributor

This also simplifies the release process for krew, because the version
number does not need to be updated when releasing a new version.

Fixes #...
Related issue: #...

This also simplifies the release process for krew, because the version
number does not need to be updated when releasing a new version.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2020
@corneliusweig
Copy link
Contributor Author

@ahmetb was there a particular reason why the version should be hardcoded and thus visible that I'm not aware of?

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #513 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   59.12%   59.12%           
=======================================
  Files          23       23           
  Lines        1003     1003           
=======================================
  Hits          593      593           
  Misses        350      350           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1339f...30e0bb3. Read the comment docs.

@ahmetb
Copy link
Member

ahmetb commented Feb 27, 2020

I think we didn’t know “latest” worked?
That said I don’t understand removing the tagging instructions in Releasing.md.

@corneliusweig
Copy link
Contributor Author

Oh it's because for a release we needed to adjust the hardcoded version number in README.md. That change needed to be committed, pushed, built, and fetched. All of these steps can now be skipped. The tagging step is still there I hope :).

@ahmetb
Copy link
Member

ahmetb commented Feb 27, 2020

Hmm but we still need this:

       git commit -m "Release ${TAG:?TAG required}"	

This ensures we have a clean commit that tags the release (we can add --allow-empty).

I frequently follow this pattern in my repos, it helps a lot in the GitHub web UI, as users go to a "commit" that explains the tag; not some irrelevant patch.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2020
@corneliusweig
Copy link
Contributor Author

corneliusweig commented Feb 27, 2020

Ok, that makes sense. Added back the instructions for creating a release commit.

@ahmetb
Copy link
Member

ahmetb commented Feb 28, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9b5620c into kubernetes-sigs:master Feb 28, 2020
@corneliusweig corneliusweig deleted the w/link-to-latest branch March 1, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants