Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move install docs to the website, add "moved" notices #522

Merged
merged 6 commits into from
Mar 2, 2020

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Feb 28, 2020

  • refactor README, USER_GUIDE, DEVELOPER_GUIDE with notes indicating they are
    moved to the website.

  • move installation instructions from README to the user guide.

Related issue: #515

* refactor README, USER_GUIDE, DEVELOPER_GUIDE with notes indicating they are
  moved to the website.

* move installation instructions from README to the user guide.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 28, 2020
@ahmetb ahmetb changed the title Move docs to the website Move install docs to the website, add "moved" notices Feb 28, 2020
@corneliusweig
Copy link
Contributor

We need to coordinate this with kubernetes/kubernetes#88593

Copy link
Contributor

@corneliusweig corneliusweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good. However, I found a few paragraphs in our old docs which are no longer present in our new site. Can you have a look?

docs/NAMING_GUIDE.md Outdated Show resolved Hide resolved
docs/USER_GUIDE.md Show resolved Hide resolved
docs/USER_GUIDE.md Show resolved Hide resolved
docs/DEVELOPER_GUIDE.md Show resolved Hide resolved
docs/DEVELOPER_GUIDE.md Show resolved Hide resolved
docs/DEVELOPER_GUIDE.md Show resolved Hide resolved
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov-io

This comment has been minimized.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb ahmetb mentioned this pull request Mar 2, 2020
8 tasks
@corneliusweig
Copy link
Contributor

corneliusweig commented Mar 2, 2020

Nice work!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ae43a27 into kubernetes-sigs:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants