site: add gitinfo and edit links to footer #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
ahmetb
force-pushed
the
site-footer-gitinfo
branch
from
ffda53e
to
dc40bf3
Compare
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
=======================================
Coverage 58.73% 58.73%
=======================================
Files 23 23
Lines 1013 1013
=======================================
Hits 595 595
Misses 359 359
Partials 59 59Continue to review full report at Codecov.
|
ahmetb
changed the title
k8s-ci-robot
added
size/M
* pass page variables to footer
* use .GitInfo and .File variables to show something like this in the footer
for each page:
[Edit Page] - Built from commit [xxxx]
* enableGitInfo both locally and on Netlify builds
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
ahmetb
force-pushed
the
site-footer-gitinfo
branch
from
dc40bf3
to
42fa974
Compare
|
Looks really nice! Thanks for your love to all the little details that make a great docs site! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass page variables to footer
use .GitInfo and .File variables to show something like this in the footer
for each page:
enableGitInfo both locally and on Netlify builds