Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site: Alternative layout #540

Merged
merged 1 commit into from
Mar 10, 2020
Merged

site: Alternative layout #540

merged 1 commit into from
Mar 10, 2020

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Mar 8, 2020

Instead of a shadowed box in the middle of the screen, sticking navbar to the
top and floating content in the middle. This is a bit more consistent with
current design patterns and more mobile-friendly.

If we like the preview, we can consider incorporating.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2020
@ahmetb
site: Alternative layout
af6141c 
Instead of a shadowed box in the middle of the screen, sticking navbar to the
top and floating content in the middle. This is a bit more consistent with
current design patterns and more mobile-friendly.

If we like the preview, we can consider incorporating.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@corneliusweig
Copy link
Contributor

In Chrome 80, the top nav bar doesn't stick. It scrolls away with the remaining content. Is that the intended behavior?

Other than that, the new page layout looks nice. It's a good idea to adopt a more modern design.

@ahmetb
Copy link
Member Author

ahmetb commented Mar 9, 2020

In Chrome 80, the top nav bar doesn't stick. It scrolls away with the remaining content. Is that the intended behavior?

Intended, but can be easily corrected. I didn't mean "stick" in that way but we can make it sticky/fixed.

@corneliusweig
Copy link
Contributor

/lgtm
/approve
Let's decide on the stickiness in a follow-up.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit c434f51 into kubernetes-sigs:master Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@corneliusweig corneliusweig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmetb @corneliusweig @k8s-ci-robot