Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/info: Support for multiple indexes #563

Merged
merged 2 commits into from
Mar 29, 2020

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Mar 28, 2020

Somewhat breaking change. krew info now looks up ONLY available plugins
(no more looking at installed plugin receipts). The supported syntaxes are:

kubectl krew info NAME # assumes 'default'
kubectl krew info INDEX/NAME

With this change, info cmd will no longer work with plugins installed via
--manifest (as we won't be looking at installation receipts anymore).

/area multi-index
/assign @corneliusweig
cc: @chriskim06
Related issue: #483
fixes #559

Somewhat breaking change. `krew info` now looks up ONLY available plugins
(no more looking at installed plugin receipts). The supported syntaxes are:

    kubectl krew info NAME # assumes 'default'
    kubectl krew info INDEX/NAME

With this change, `info` cmd will no longer work with plugins installed via
`--manifest` (as we won't be looking at installation receipts anymore).

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot
Copy link
Contributor

@ahmetb: GitHub didn't allow me to assign the following users: corneliuseweig.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Somewhat breaking change. krew info now looks up ONLY available plugins
(no more looking at installed plugin receipts). The supported syntaxes are:

kubectl krew info NAME # assumes 'default'
kubectl krew info INDEX/NAME

With this change, info cmd will no longer work with plugins installed via
--manifest (as we won't be looking at installation receipts anymore).

/area multi-index
/assign @corneliuseweig
cc: @chriskim06
Related issue: #483

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/multi-index cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2020
cmd/krew/cmd/info.go Outdated Show resolved Hide resolved
cmd/krew/cmd/info.go Outdated Show resolved Hide resolved
cmd/krew/cmd/info.go Outdated Show resolved Hide resolved
cmd/krew/cmd/info.go Outdated Show resolved Hide resolved
integration_test/info_test.go Show resolved Hide resolved
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@chriskim06 chriskim06 mentioned this pull request Mar 29, 2020
22 tasks
@corneliusweig
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2d78e6f into kubernetes-sigs:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/multi-index cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: make krew info work with multiple indexes
3 participants