Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that gnu utils are required in mac #578

Merged

Conversation

naxhh
Copy link
Contributor

@naxhh naxhh commented Mar 31, 2020

Document that GNU binaries are required for the support scripts.

grep and sed are not part of the coreutils package so we need to install them as another package.

grep and sed are not part of coreutils package so we need to install
them aside
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2020
@naxhh
Copy link
Contributor Author

naxhh commented Mar 31, 2020

/assign cornelius

as we talked about this in #krew slack

@k8s-ci-robot
Copy link
Contributor

@naxhh: GitHub didn't allow me to assign the following users: cornelius.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign cornelius

as we talked about this in #krew slack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@naxhh
Copy link
Contributor Author

naxhh commented Mar 31, 2020

I guess not then. ping @corneliusweig

docs/CONTRIBUTOR_GUIDE.md Outdated Show resolved Hide resolved
docs/CONTRIBUTOR_GUIDE.md Outdated Show resolved Hide resolved
docs/CONTRIBUTOR_GUIDE.md Outdated Show resolved Hide resolved
@ahmetb
Copy link
Member

ahmetb commented Mar 31, 2020

Thanks for taking a stab at this. We've discussed this before #364 but I think we can accept docs on this since more and more contributors will go through it.

Copy link
Contributor

@corneliusweig corneliusweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I hope this will make it easier for OSX contributors to get set up.
Also related: #482

@naxhh
Copy link
Contributor Author

naxhh commented Apr 2, 2020

Changes applied, hope it's good now.

@ahmetb
Copy link
Member

ahmetb commented Apr 2, 2020

thanks
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, naxhh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 368a3ec into kubernetes-sigs:master Apr 2, 2020
@naxhh naxhh deleted the docs-document-mac-requirements branch April 2, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants