Show new/updated plugins list after index updates

[ahmetb]

• Adjusted the showUpdatedPlugins logic to behave well with multi-index mode
• Adjusted the "Updated the local copy of plugin index" message for multi-index
  mode. (We won't show index name if it's 'default' index.)

Related issue: #566
/area multi-index
/assign @corneliusweig
/assign @chriskim06

[chriskim06]

Thanks for taking care of this! It LGTM, do you think it would be worth modifying this integration test to check for upgrade available for plugins from custom indexes or is that not needed?

[ahmetb]

Yeah, I got lazy about tests. I will try to update.

[corneliusweig]

/lgtm
/approve
/hold
In case you want to follow up in a different PR.

[ahmetb]

nit: this message is shown even if the EnusreUpdated() call failed with an error.

So I fixed this bug and pushed a change. But I'm not touching the tests. That's mostly because I noticed we'd duplicate a lot of test code (as adding custom indexes takes a lot of code right now).

Ideally we need an utility like:

NewTest(t).WithDefaultIndex().WithDefaultIndexMirroredAs("foo").WithCustomIndex(name, src). ...

but since there's a feature gate around the multi-index features, I'm refraining from developing this pattern.

[corneliusweig]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[corneliusweig]

/hold cancel