Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim and minify SVG assets #608

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Trim and minify SVG assets #608

merged 1 commit into from
Jun 7, 2020

Conversation

corneliusweig
Copy link
Contributor

Fixes #533

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 7, 2020
@ahmetb
Copy link
Member

ahmetb commented Jun 7, 2020

What sort of tool did you use to do this? 🤔

@ahmetb
Copy link
Member

ahmetb commented Jun 7, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4ec386c into kubernetes-sigs:master Jun 7, 2020
@corneliusweig
Copy link
Contributor Author

https://inkscape.org/ (has nice auto-trim) + https://jakearchibald.github.io/svgomg/ (lots of options to reduce size)

@corneliusweig corneliusweig deleted the w/trim-logo branch June 7, 2020 19:20
@ferhatelmas
Copy link
Contributor

ferhatelmas commented Jun 7, 2020 •
edited

This might be enabled for the repo, that does this job automatically: https://github.com/marketplace/imgbot

@corneliusweig
Copy link
Contributor Author

imgbot looks nice. I wonder if there's a k8s policy about what bots can be enabled?

@ahmetb
Copy link
Member

ahmetb commented Jun 7, 2020

Since we don’t get images on an ongoing basis we prob don’t need a bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb Awaiting requested review from ahmetb

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logo: Crop logo assets to the content
4 participants
@corneliusweig @ahmetb @k8s-ci-robot @ferhatelmas