Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more detail to error logging when dealing with bad index/plugin #620

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Add more detail to error logging when dealing with bad index/plugin #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1461070
Add index name to search error output
chriskim06 Jul 14, 2020
039288a
Add file name to error string
chriskim06 Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/krew/cmd/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Examples:
for _, idx := range indexes {
ps, err := indexscanner.LoadPluginListFromFS(paths.IndexPluginsPath(idx.Name))
if err != nil {
return errors.Wrap(err, "failed to load the list of plugins from the index")
return errors.Wrapf(err, "failed to load the list of plugins from the index %q", idx.Name)
}
for _, p := range ps {
plugins = append(plugins, pluginEntry{p, idx.Name})
Expand Down
2 changes: 1 addition & 1 deletion internal/index/indexscanner/scanner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func readFromFile(path string, as interface{}) error {
return err
}
err = decodeFile(f, &as)
return errors.Wrap(err, "failed to parse yaml file")
return errors.Wrapf(err, "failed to parse yaml file %q", path)
}

// decodeFile tries to decode a plugin/receipt
Expand Down